URL: https://github.com/SSSD/sssd/pull/5512 Title: #5512: TEST: Add function to control services
pbrezina commented: """ What I do not like is that you started writing tests in python instead of bash, but you did not get rid of the bashism. You do not take advantage of python, you are instead converting everything basicly 1 to 1 from bash to python. But this is a discussion for another place, another day. This is just when it really caught my eyes. """ See the full comment at https://github.com/SSSD/sssd/pull/5512#issuecomment-784974819
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure