URL: https://github.com/SSSD/sssd/pull/5546 Title: #5546: kcm: add GET_CRED_LIST for faster iteration
sumit-bose commented: """ Hi, the patches work well for me. The feature is already covered by the current KCM integration tests, i.e. if the krb5 client library supports the extension it will be used in the tests. However there is no indication in the tests if the GET_CRED_LIST or GET_CRED_UUID_LIST is used. I wonder if it would be good to have such indication to avoid regressions on platform where we know that the extension is supported? About `KCM_MIT_OFFSET`, I think it would be worth to add a comment explaining where this is coming from, e.g. that it is the opcode of the first call of the MIT extension. bye, Sumit """ See the full comment at https://github.com/SSSD/sssd/pull/5546#issuecomment-810092973
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
