URL: https://github.com/SSSD/sssd/pull/5558
Title: #5558: p11_child: Add partial verification support

sumit-bose commented:
"""
> Mhmh, not sure what's this failure is about:
> 
> ```
> rpmbuild --define "_topdir /shared/sssd/rpmbuild" -ba SPECS/sssd.spec
> setting SOURCE_DATE_EPOCH=1611187200
> error: Failed build dependencies:
>       libfaketime is needed by sssd-2.4.3-0.fc34.x86_64
> ```

Hi,

this means that the package is missing in the CI VM running the tests. I was 
under the assumption that this package is installed since it is already 
required in the general CI  dependencies `contrib/ci/deps.sh`. However the CI 
is executed with `--no-deps`, so it is not checked at all.

Currently there is a configure check if `faketime` is available and the tests 
needing it are skipped if it is not installed. Do I understand correctly that 
your patches do not need `faketime` and you add the BuildRequires to just run 
the missing existing tests? If that's the case I would recommend to drop this 
BuildRequires for the time being.

I will create a pull-request for sssd-test-suite to get faketime installed to 
the CI VMs.

bye,
Sumit


"""

See the full comment at 
https://github.com/SSSD/sssd/pull/5558#issuecomment-815868956
_______________________________________________
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to