URL: https://github.com/SSSD/sssd/pull/5600 Author: DeepakDas7 Title: #5600: SSSD Log: log_bad_address_msg_modification Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5600/head:pr5600 git checkout pr5600
From ccd48fdf724a8efe4e1740a14164c8811a37f854 Mon Sep 17 00:00:00 2001 From: Deepak Das <d...@redhat.com> Date: Fri, 23 Apr 2021 11:11:02 +0530 Subject: [PATCH] SSSD Log: log_bad_address_msg_modification Improve Log Containing Bad Address string Resolves: https://github.com/SSSD/sssd/issues/5577 --- src/providers/ad/ad_gpo.c | 12 +++++++++--- src/providers/data_provider_fo.c | 10 ++++++++-- src/providers/ldap/sdap_async_connection.c | 11 +++++++++-- 3 files changed, 26 insertions(+), 7 deletions(-) diff --git a/src/providers/ad/ad_gpo.c b/src/providers/ad/ad_gpo.c index 4ef6a7219c..181b170986 100644 --- a/src/providers/ad/ad_gpo.c +++ b/src/providers/ad/ad_gpo.c @@ -2447,9 +2447,15 @@ ad_gpo_process_gpo_done(struct tevent_req *subreq) ret = sdap_id_op_done(state->sdap_op, ret, &dp_error); if (ret != EOK && ret != ENOENT) { - DEBUG(SSSDBG_OP_FAILURE, - "Unable to get GPO list: [%d](%s)\n", - ret, sss_strerror(ret)); + if (ret == EFAULT || ret == EIO || ret == EPERM) { + DEBUG(SSSDBG_OP_FAILURE, + "Unable to get GPO list from servr %s: [%d](%s)\n", + state->ad_hostname, ret, sss_strerror(ret)); + } else { + DEBUG(SSSDBG_OP_FAILURE, + "Unable to get GPO list: [%d](%s)\n", + ret, sss_strerror(ret)); + } goto done; } else if (ret == ENOENT) { DEBUG(SSSDBG_TRACE_FUNC, diff --git a/src/providers/data_provider_fo.c b/src/providers/data_provider_fo.c index 0dfbb04b0f..bbd666da67 100644 --- a/src/providers/data_provider_fo.c +++ b/src/providers/data_provider_fo.c @@ -575,8 +575,14 @@ static void be_resolve_server_done(struct tevent_req *subreq) return; fail: - DEBUG(SSSDBG_TRACE_LIBS, - "Server resolution failed: [%d]: %s\n", ret, sss_strerror(ret)); + if (ret == EFAULT || ret == EIO || ret == EPERM) { + DEBUG(SSSDBG_TRACE_LIBS, + "Server [%s] resolution failed: [%d]: %s\n", + fo_get_server_name(state->srv),ret, sss_strerror(ret)); + } else { + DEBUG(SSSDBG_TRACE_LIBS, + "Server resolution failed: [%d]: %s\n", ret, sss_strerror(ret)); + } state->svc->first_resolved = NULL; tevent_req_error(req, ret); } diff --git a/src/providers/ldap/sdap_async_connection.c b/src/providers/ldap/sdap_async_connection.c index eead3f119a..8bd80d4ccf 100644 --- a/src/providers/ldap/sdap_async_connection.c +++ b/src/providers/ldap/sdap_async_connection.c @@ -1274,8 +1274,15 @@ static void sdap_kinit_done(struct tevent_req *subreq) } - DEBUG(SSSDBG_CONF_SETTINGS, - "Could not get TGT: %d [%s]\n", result, sss_strerror(result)); + if (result == EFAULT || result == EIO || result == EPERM) { + DEBUG(SSSDBG_CONF_SETTINGS, + "Could not get TGT from server %s: %d [%s]\n", + fo_get_server_name(state->kdc_srv), result, sss_strerror(result)); + } else { + DEBUG(SSSDBG_CONF_SETTINGS, + "Could not get TGT: %d [%s]\n", result, sss_strerror(result)); + } + tevent_req_error(req, ERR_AUTH_FAILED); }
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
