URL: https://github.com/SSSD/sssd/pull/5750 Title: #5750: fix compilation warnings
alexey-tikhonov commented: """ About 2nd patch: can we increase log level in `DEBUG(SSSDBG_TRACE_ALL, "sss_getenv() failed\n");` in `sysdb_ldb_connect()`? Users of this function don't quote fail reason: it's just `DEBUG(SSSDBG_CRIT_FAILURE, "sysdb_ldb_connect failed.\n");` (I know this is original code, but so close) Otherwise patch looks good to me. Covscan: https://cov01.lab.eng.brq.redhat.com/covscanhub/task/230741/log/fixed.err """ See the full comment at https://github.com/SSSD/sssd/pull/5750#issuecomment-904522306
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
