URL: https://github.com/SSSD/sssd/pull/5722
Title: #5722: NSS client: avoid using NETDB_INTERNAL if daemon is not available

sumit-bose commented:
"""
> Hi @sumit-bose , did you have a chance to take a look at this?

Hi,

thanks for the reminder. I'm fine with the patch as it is. Imo `NETDB_INTERNAL` 
should still be used after calling `sss_nss_gethost_readrep()` because the most 
common issue would be `ERANGE` where the caller should increase the buffer 
immediately. There is `EBASMSG` as well, which mostly would indicate internal 
errors, like e.g. not enough data send by the nss responder. Here I think a 
hard error would be better instead of a fallback to other configured modules 
which would hide the issue. So, ACK.

bye,
Sumit
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/5722#issuecomment-933294156
_______________________________________________
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to