commit: a2ae4cc9a16e211c8a128ba10d22a85431f093ab From: Eric Paris <[email protected]> Date: Tue, 23 Nov 2010 18:18:37 -0500 Subject: [PATCH] inotify: stop kernel memory leak on file creation failure
If inotify_init is unable to allocate a new file for the new inotify group we leak the new group. This patch drops the reference on the group on file allocation failure. Reported-by: Vegard Nossum <[email protected]> cc: [email protected] Signed-off-by: Eric Paris <[email protected]> --- fs/notify/inotify/inotify_user.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/notify/inotify/inotify_user.c b/fs/notify/inotify/inotify_user.c index 444c305..4cd5d5d 100644 --- a/fs/notify/inotify/inotify_user.c +++ b/fs/notify/inotify/inotify_user.c @@ -752,6 +752,7 @@ SYSCALL_DEFINE1(inotify_init1, int, flags) if (ret >= 0) return ret; + fsnotify_put_group(group); atomic_dec(&user->inotify_devs); out_free_uid: free_uid(user); _______________________________________________ stable mailing list [email protected] http://linux.kernel.org/mailman/listinfo/stable
