2.6.37-stable review patch. If anyone has any objections, please let us know.
------------------
From: Eric Dumazet <eric.duma...@gmail.com>
commit ceaaec98ad99859ac90ac6863ad0a6cd075d8e0e upstream.
commit 9b5e383c11b08784 (net: Introduce
unregister_netdevice_many()) left an active LIST_HEAD() in
rollback_registered(), with possible memory corruption.
Even if device is freed without touching its unreg_list (and therefore
touching the previous memory location holding LISTE_HEAD(single), better
close the bug for good, since its really subtle.
(Same fix for default_device_exit_batch() for completeness)
Reported-by: Michal Hocko <mho...@suse.cz>
Tested-by: Michal Hocko <mho...@suse.cz>
Reported-by: Eric W. Biderman <ebider...@xmission.com>
Tested-by: Eric W. Biderman <ebider...@xmission.com>
Signed-off-by: Linus Torvalds <torva...@linux-foundation.org>
Signed-off-by: Eric Dumazet <eric.duma...@gmail.com>
CC: Ingo Molnar <mi...@elte.hu>
CC: Octavian Purdila <opurd...@ixiacom.com>
Signed-off-by: David S. Miller <da...@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gre...@suse.de>
---
net/core/dev.c | 2 ++
1 file changed, 2 insertions(+)
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -4945,6 +4945,7 @@ static void rollback_registered(struct n
list_add(&dev->unreg_list, &single);
rollback_registered_many(&single);
+ list_del(&single);
}
unsigned long netdev_fix_features(unsigned long features, const char *name)
@@ -6114,6 +6115,7 @@ static void __net_exit default_device_ex
}
}
unregister_netdevice_many(&dev_kill_list);
+ list_del(&dev_kill_list);
rtnl_unlock();
}
_______________________________________________
stable mailing list
stable@linux.kernel.org
http://linux.kernel.org/mailman/listinfo/stable
