This is a note to let you know that I've just added the patch titled
drivers/net: Call netif_carrier_off at the end of the probe
to the 2.6.37-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
drivers-net-call-netif_carrier_off-at-the-end-of-the-probe.patch
and it can be found in the queue-2.6.37 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <sta...@kernel.org> know about it.
>From 0d672e9f8ac320c6d1ea9103db6df7f99ea20361 Mon Sep 17 00:00:00 2001
From: Ivan Vecera <ivec...@redhat.com>
Date: Tue, 15 Feb 2011 02:08:39 +0000
Subject: drivers/net: Call netif_carrier_off at the end of the probe
From: Ivan Vecera <ivec...@redhat.com>
commit 0d672e9f8ac320c6d1ea9103db6df7f99ea20361 upstream.
Without calling of netif_carrier_off at the end of the probe the operstate
is unknown when the device is initially opened. By default the carrier is
on so when the device is opened and netif_carrier_on is called the link
watch event is not fired and operstate remains zero (unknown).
This patch fixes this behavior in forcedeth and r8169.
Signed-off-by: Ivan Vecera <ivec...@redhat.com>
Acked-by: Francois Romieu <rom...@fr.zoreil.com>
Signed-off-by: David S. Miller <da...@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gre...@suse.de>
---
drivers/net/forcedeth.c | 2 ++
drivers/net/r8169.c | 2 ++
2 files changed, 4 insertions(+)
--- a/drivers/net/forcedeth.c
+++ b/drivers/net/forcedeth.c
@@ -5816,6 +5816,8 @@ static int __devinit nv_probe(struct pci
goto out_error;
}
+ netif_carrier_off(dev);
+
dev_printk(KERN_INFO, &pci_dev->dev, "ifname %s, PHY OUI 0x%x @ %d, "
"addr %2.2x:%2.2x:%2.2x:%2.2x:%2.2x:%2.2x\n",
dev->name,
--- a/drivers/net/r8169.c
+++ b/drivers/net/r8169.c
@@ -3236,6 +3236,8 @@ rtl8169_init_one(struct pci_dev *pdev, c
if (pci_dev_run_wake(pdev))
pm_runtime_put_noidle(&pdev->dev);
+ netif_carrier_off(dev);
+
out:
return rc;
Patches currently in stable-queue which might be from ivec...@redhat.com are
queue-2.6.37/r8169-prevent-rxfifo-induced-loops-in-the-irq-handler.patch
queue-2.6.37/r8169-use-rxfifo-overflow-workaround-for-8168c-chipset.patch
queue-2.6.37/drivers-net-call-netif_carrier_off-at-the-end-of-the-probe.patch
queue-2.6.37/r8169-rxfifo-overflow-oddities-with-8168-chipsets.patch
_______________________________________________
stable mailing list
stable@linux.kernel.org
http://linux.kernel.org/mailman/listinfo/stable
