2.6.35-longterm review patch. If anyone has any objections, please let me know.
------------------ From: J. R. Okajima <[email protected]> commit 0702099bd86c33c2dcdbd3963433a61f3f503901 upstream. By the commit af7fa16 2010-08-03 NFS: Fix up the fsync code close(2) became returning the non-zero value even if it went well. nfs_file_fsync() should return 0 when "status" is positive. Signed-off-by: J. R. Okajima <[email protected]> Signed-off-by: Trond Myklebust <[email protected]> Signed-off-by: Tim Gardner <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]> Signed-off-by: Andi Kleen <[email protected]> --- fs/nfs/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6.35.y/fs/nfs/file.c =================================================================== --- linux-2.6.35.y.orig/fs/nfs/file.c 2011-03-29 22:51:19.419226280 -0700 +++ linux-2.6.35.y/fs/nfs/file.c 2011-03-29 23:03:00.750280971 -0700 @@ -222,7 +222,7 @@ have_error |= test_bit(NFS_CONTEXT_ERROR_WRITE, &ctx->flags); if (have_error) ret = xchg(&ctx->error, 0); - if (!ret) + if (!ret && status < 0) ret = status; return ret; } _______________________________________________ stable mailing list [email protected] http://linux.kernel.org/mailman/listinfo/stable
