This is a note to let you know that I've just added the patch titled
PM / Hibernate: Fix free_unnecessary_pages()
to the 2.6.33-longterm tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/longterm/longterm-queue-2.6.33.git;a=summary
The filename of the patch is:
pm-hibernate-fix-free_unnecessary_pages.patch
and it can be found in the queue-2.6.33 subdirectory.
If you, or anyone else, feels it should not be added to the 2.6.33 longterm
tree,
please let <sta...@kernel.org> know about it.
>From 4d4cf23cdde2f8f9324f5684a7f349e182039529 Mon Sep 17 00:00:00 2001
From: "Rafael J. Wysocki" <r...@sisk.pl>
Date: Wed, 6 Jul 2011 20:15:23 +0200
Subject: PM / Hibernate: Fix free_unnecessary_pages()
From: "Rafael J. Wysocki" <r...@sisk.pl>
commit 4d4cf23cdde2f8f9324f5684a7f349e182039529 upstream.
There is a bug in free_unnecessary_pages() that causes it to
attempt to free too many pages in some cases, which triggers the
BUG_ON() in memory_bm_clear_bit() for copy_bm. Namely, if
count_data_pages() is initially greater than alloc_normal, we get
to_free_normal equal to 0 and "save" greater from 0. In that case,
if the sum of "save" and count_highmem_pages() is greater than
alloc_highmem, we subtract a positive number from to_free_normal.
Hence, since to_free_normal was 0 before the subtraction and is
an unsigned int, the result is converted to a huge positive number
that is used as the number of pages to free.
Fix this bug by checking if to_free_normal is actually greater
than or equal to the number we're going to subtract from it.
Signed-off-by: Rafael J. Wysocki <r...@sisk.pl>
Reported-and-tested-by: Matthew Garrett <m...@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gre...@suse.de>
---
kernel/power/snapshot.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
--- a/kernel/power/snapshot.c
+++ b/kernel/power/snapshot.c
@@ -1193,7 +1193,11 @@ static void free_unnecessary_pages(void)
to_free_highmem = alloc_highmem - save;
} else {
to_free_highmem = 0;
- to_free_normal -= save - alloc_highmem;
+ save -= alloc_highmem;
+ if (to_free_normal > save)
+ to_free_normal -= save;
+ else
+ to_free_normal = 0;
}
memory_bm_position_reset(©_bm);
Patches currently in longterm-queue-2.6.33 which might be from r...@sisk.pl are
/home/gregkh/linux/longterm/longterm-queue-2.6.33/queue-2.6.33/pm-hibernate-avoid-hitting-oom-during-preallocation-of-memory.patch
/home/gregkh/linux/longterm/longterm-queue-2.6.33/queue-2.6.33/pm-free-memory-bitmaps-if-opening-dev-snapshot-fails.patch
/home/gregkh/linux/longterm/longterm-queue-2.6.33/queue-2.6.33/pm-hibernate-fix-free_unnecessary_pages.patch
_______________________________________________
stable mailing list
stable@linux.kernel.org
http://linux.kernel.org/mailman/listinfo/stable
