On Fri, 2011-07-15 at 12:02 +0200, Peter Zijlstra wrote: > On Fri, 2011-07-15 at 10:30 +0200, Peter Zijlstra wrote: > > On Thu, 2011-07-14 at 17:35 -0700, john stultz wrote: > > > > > > Peter/Ingo: Can you take a look at the above and let me know if you find > > > it too disagreeable? > > > > I'm not quite sure of the calling conditions of set_cyc2ns_scale(), but > > there's two sites in there that do: > > > > + local_irq_save(flags); > > > > + data = kmalloc(sizeof(*data), GFP_KERNEL); > > > > + local_irq_restore(flags); > > > > Clearly that's not going to work well at all. > > Furthermore there is a distinct lack of error handling there, it assumes > the allocation always succeeds.
Yes, both of those issues are embarrassing. Thanks for pointing them out. I'll take another swing at it. thanks -john _______________________________________________ stable mailing list stable@linux.kernel.org http://linux.kernel.org/mailman/listinfo/stable
