Please consider including the following commit in 2.6.39.y, I was
just bitten by NULL pointer dereference it fixes...
----------------------------------------------------------------------
commit 06e3a0db621906d17d5f17d50ed81f268e30a094
Author: Amir Goldstein <amir7...@gmail.com>
Date: Mon May 16 09:59:13 2011 -0400
ext4: fix oops in ext4_quota_off()
If quota is not enabled when ext4_quota_off() is called, we must not
dereference quota file inode since it is NULL. Check properly for
this.
This fixes a bug in commit 21f976975cbe (ext4: remove unnecessary
[cm]time update of quota file), which was merged for 2.6.39-rc3.
Reported-by: Amir Goldstein <amir7...@users.sf.net>
Signed-off-by: Amir Goldstein <amir7...@users.sf.net>
Signed-off-by: Jan Kara <j...@suse.cz>
Signed-off-by: "Theodore Ts'o" <ty...@mit.edu>
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index e28c0f2..e6ea384 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -4635,6 +4635,9 @@ static int ext4_quota_off(struct super_block *sb, int
type)
if (test_opt(sb, DELALLOC))
sync_filesystem(sb);
+ if (!inode)
+ goto out;
+
/* Update modification times of quota files when userspace can
* start looking at them */
handle = ext4_journal_start(inode, 1);
----------------------------------------------------------------------
Cheers,
Chris.
_______________________________________________
stable mailing list
stable@linux.kernel.org
http://linux.kernel.org/mailman/listinfo/stable
