Please consider including the following commit in 2.6.39.y, I was just bitten by NULL pointer dereference it fixes...
---------------------------------------------------------------------- commit 06e3a0db621906d17d5f17d50ed81f268e30a094 Author: Amir Goldstein <[email protected]> Date: Mon May 16 09:59:13 2011 -0400 ext4: fix oops in ext4_quota_off() If quota is not enabled when ext4_quota_off() is called, we must not dereference quota file inode since it is NULL. Check properly for this. This fixes a bug in commit 21f976975cbe (ext4: remove unnecessary [cm]time update of quota file), which was merged for 2.6.39-rc3. Reported-by: Amir Goldstein <[email protected]> Signed-off-by: Amir Goldstein <[email protected]> Signed-off-by: Jan Kara <[email protected]> Signed-off-by: "Theodore Ts'o" <[email protected]> diff --git a/fs/ext4/super.c b/fs/ext4/super.c index e28c0f2..e6ea384 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -4635,6 +4635,9 @@ static int ext4_quota_off(struct super_block *sb, int type) if (test_opt(sb, DELALLOC)) sync_filesystem(sb); + if (!inode) + goto out; + /* Update modification times of quota files when userspace can * start looking at them */ handle = ext4_journal_start(inode, 1); ---------------------------------------------------------------------- Cheers, Chris. _______________________________________________ stable mailing list [email protected] http://linux.kernel.org/mailman/listinfo/stable
