On Fri, 22 Jul 2011 20:10:09 -0400 Mike Frysinger wrote: > On Fri, Jul 22, 2011 at 19:26, Randy Dunlap wrote: > > On Fri, 22 Jul 2011 19:13:14 -0400 Mike Frysinger wrote: > >> On Fri, Jul 22, 2011 at 18:33, <[email protected]> wrote: > >> > Subject: drivers/firmware/sigma.c needs MODULE_LICENSE > >> > From: Randy Dunlap <[email protected]> > >> > > >> > Fix module tainting message: > >> > sigma: module license 'unspecified' taints kernel. > >> > > >> > Signed-off-by: Randy Dunlap <[email protected]> > >> > Acked-by: Mike Frysinger <[email protected]> > >> > >> not that it really matters, but i did s-o-b on this rather than a-b ;) > > > > and Andrew converted it to A-B, which is correct. > > You would use S-O-B if you were merging it. > > meh, last i looked s-o-b was more formal than an ack. as in "i'd sign > off on this" vs "the idea sounds sane and the patch doesnt catch my > eye, but i'll just ack that it's a good idea". but i guess things > have changed according to the submitting patches doc.
If you want it to be more formal (but you are not in the merge path), you can use Reviewed-by: instead of Acked-by: --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** _______________________________________________ stable mailing list [email protected] http://linux.kernel.org/mailman/listinfo/stable
