2.6.35-longterm review patch. If anyone has any objections, please let me know.
------------------ From: Jeff Layton <[email protected]> commit 26c4c170731f00008f4317a2888a0a07ac99d90d upstream. On a remount, the VFS layer will clear the MS_SYNCHRONOUS bit on the assumption that the flags on the mount syscall will have it set if the remounted fs is supposed to keep it. In the case of "noac" though, MS_SYNCHRONOUS is implied. A remount of such a mount will lose the MS_SYNCHRONOUS flag since "sync" isn't part of the mount options. Reported-by: Max Matveev <[email protected]> Signed-off-by: Jeff Layton <[email protected]> Signed-off-by: Trond Myklebust <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]> Signed-off-by: Andi Kleen <[email protected]> --- fs/nfs/super.c | 9 +++++++++ 1 file changed, 9 insertions(+) Index: linux-2.6.35.y/fs/nfs/super.c =================================================================== --- linux-2.6.35.y.orig/fs/nfs/super.c +++ linux-2.6.35.y/fs/nfs/super.c @@ -2001,6 +2001,15 @@ nfs_remount(struct super_block *sb, int if (error < 0) goto out; + /* + * noac is a special case. It implies -o sync, but that's not + * necessarily reflected in the mtab options. do_remount_sb + * will clear MS_SYNCHRONOUS if -o sync wasn't specified in the + * remount options, so we have to explicitly reset it. + */ + if (data->flags & NFS_MOUNT_NOAC) + *flags |= MS_SYNCHRONOUS; + /* compare new mount options with old ones */ error = nfs_compare_remount_data(nfss, data); out: _______________________________________________ stable mailing list [email protected] http://linux.kernel.org/mailman/listinfo/stable
