From: Nishanth Aravamudan <n...@us.ibm.com>

It seems that 7bf693951a8e ("console: allow to retain boot console via
boot option keep_bootcon") doesn't always achieve what it aims, as when
printk_late_init() runs it unconditionally turns off all boot consoles. 
With this patch, I am able to see more messages on the boot console in KVM
guests than I can without, when keep_bootcon is specified.

I think it is appropriate for the relevant -stable trees.  However, it's
more of an annoyance than a serious bug (ideally you don't need to keep
the boot console around as console handover should be working -- I was
encountering a situation where the console handover wasn't working and not
having the boot console available meant I couldn't see why).

Signed-off-by: Nishanth Aravamudan <n...@us.ibm.com>
Cc: David S. Miller <da...@davemloft.net>
Cc: Alan Cox <a...@lxorguk.ukuu.org.uk>
Cc: Greg KH <gre...@suse.de>
Acked-by: Fabio M. Di Nitto <fdini...@redhat.com>
Cc: <sta...@kernel.org>         [2.6.39.x, 3.0.x]
Signed-off-by: Andrew Morton <a...@linux-foundation.org>
---

 kernel/printk.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN 
kernel/printk.c~kernel-printk-do-not-turn-off-bootconsole-in-printk_late_init-if-keep_bootcon
 kernel/printk.c
--- 
a/kernel/printk.c~kernel-printk-do-not-turn-off-bootconsole-in-printk_late_init-if-keep_bootcon
+++ a/kernel/printk.c
@@ -1604,7 +1604,7 @@ static int __init printk_late_init(void)
        struct console *con;
 
        for_each_console(con) {
-               if (con->flags & CON_BOOT) {
+               if (!keep_bootcon && con->flags & CON_BOOT) {
                        printk(KERN_INFO "turn off boot console %s%d\n",
                                con->name, con->index);
                        unregister_console(con);
_

_______________________________________________
stable mailing list
stable@linux.kernel.org
http://linux.kernel.org/mailman/listinfo/stable

Reply via email to