On Thu, 29 Mar 2012 11:32:06 -0500 Jonathan Nieder <[email protected]> wrote:
> From: Matthew Garrett <[email protected]> > Date: Tue, 27 Mar 2012 10:17:41 -0400 > > Since 3.2.12 and 3.3, some systems are failing to boot with a BUG_ON. > Some other systems using the pata_jmicron driver fail to boot because > no disks are detected. Passing pcie_aspm=force on the kernel command > line works around it. > > The cause: commit 4949be16822e ("PCI: ignore pre-1.1 ASPM quirking > when ASPM is disabled") changed the behaviour of > pcie_aspm_sanity_check() to always return 0 if aspm is disabled, in > order to avoid cases where we changed ASPM state on pre-PCIe 1.1 > devices. This skipped the secondary function of > pcie_aspm_sanity_check which was to avoid us enabling ASPM on devices > that had non-PCIe children, causing trouble later on. Move the > aspm_disabled check so we continue to honour that scenario. > > Addresses https://bugzilla.kernel.org/show_bug.cgi?id=42979 and > http://bugs.debian.org/665420 > > [jn: with more symptoms in log message] > > Reported-by: Romain Francoise <[email protected]> # kernel panic > Reported-by: Chris Holland <[email protected]> # disk detection > trouble > Signed-off-by: Matthew Garrett <[email protected]> > Cc: [email protected] > Tested-by: Hatem Masmoudi <[email protected]> # Dell Latitude E5520 > Tested-by: janek <[email protected]> # pata_jmicron with JMB362/JMB363 > Signed-off-by: Jonathan Nieder <[email protected]> > --- > Hi Andrew, > > This patch only appeared a couple of days ago[1], but it fixes a > noticeable regression so I would like to make sure the patch becomes > part of mainline and the 3.2.y- and 3.3.y-stable trees soon. Could > you pick it up for linux-next until it makes its way to the PCI tree? > > Regression was introduced between 3.3-rc7 and 3.3 and between 3.2.11 > and 3.2.12. Prevents boot on affected machines, though there is a > workaround. Details about the symptoms and fix are above. Just about the only person who wasn't copied on this email is, umm, the PCI maintainer! -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
