ISSUE: When the driver notifies a gadget of a disconnect event, a system rarely freezes.
CAUSE: When the driver calls dev->driver->disconnect(), it is not calling spin_unlock(). commit: c50a3bff0edb0acd49d8033a12ea4668e09a31ad kernel version: 3.0, 3.2, 3.3 Cc: [email protected] Signed-off-by: Felipe Balbi <[email protected]> Signed-off-by: Tomoya MORINAGA <[email protected]> --- v2: Retrieve cc-/Signed-off lists. --- drivers/usb/gadget/pch_udc.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drivers/usb/gadget/pch_udc.c b/drivers/usb/gadget/pch_udc.c index a3fcaae..6a44c92 100644 --- a/drivers/usb/gadget/pch_udc.c +++ b/drivers/usb/gadget/pch_udc.c @@ -2335,8 +2335,11 @@ static void pch_udc_svc_ur_interrupt(struct pch_udc_dev *dev) /* Complete request queue */ empty_req_queue(ep); } - if (dev->driver && dev->driver->disconnect) + if (dev->driver && dev->driver->disconnect) { + spin_unlock(&dev->lock); dev->driver->disconnect(&dev->gadget); + spin_lock(&dev->lock); + } } /** -- 1.7.7.6 -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
