This is a note to let you know that I've just added the patch titled
be2net: fix a race in be_xmit()
to the 3.0-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
be2net-fix-a-race-in-be_xmit.patch
and it can be found in the queue-3.0 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.
>From 8074e5e58716e64f4077862596756c04227b5c57 Mon Sep 17 00:00:00 2001
From: Eric Dumazet <eduma...@google.com>
Date: Thu, 7 Jun 2012 22:59:59 +0000
Subject: be2net: fix a race in be_xmit()
From: Eric Dumazet <eduma...@google.com>
[ Upstream commit cd8f76c0a0c6fce0b2cf23c9bd0123f91453f46d ]
As soon as hardware is notified of a transmit, we no longer can assume
skb can be dereferenced, as TX completion might have freed the packet.
Signed-off-by: Eric Dumazet <eduma...@google.com>
Cc: Sathya Perla <sathya.pe...@emulex.com>
Signed-off-by: David S. Miller <da...@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>
---
drivers/net/benet/be_main.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
--- a/drivers/net/benet/be_main.c
+++ b/drivers/net/benet/be_main.c
@@ -763,6 +763,8 @@ static netdev_tx_t be_xmit(struct sk_buf
copied = make_tx_wrbs(adapter, skb, wrb_cnt, dummy_wrb);
if (copied) {
+ int gso_segs = skb_shinfo(skb)->gso_segs;
+
/* record the sent skb in the sent_skb table */
BUG_ON(tx_obj->sent_skb_list[start]);
tx_obj->sent_skb_list[start] = skb;
@@ -780,8 +782,7 @@ static netdev_tx_t be_xmit(struct sk_buf
be_txq_notify(adapter, txq->id, wrb_cnt);
- be_tx_stats_update(adapter, wrb_cnt, copied,
- skb_shinfo(skb)->gso_segs, stopped);
+ be_tx_stats_update(adapter, wrb_cnt, copied, gso_segs, stopped);
} else {
txq->head = start;
dev_kfree_skb_any(skb);
Patches currently in stable-queue which might be from eduma...@google.com are
queue-3.0/be2net-fix-a-race-in-be_xmit.patch
queue-3.0/bonding-fix-corrupted-queue_mapping.patch
queue-3.0/netpoll-fix-netpoll_send_udp-bugs.patch
queue-3.0/dummy-fix-rcu_sched-self-detected-stalls.patch
queue-3.0/net-l2tp_eth-fix-kernel-panic-on-rmmod-l2tp_eth.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
