This is a note to let you know that I've just added the patch titled
ore: Remove support of partial IO request (NFS crash)
to the 3.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
ore-remove-support-of-partial-io-request-nfs-crash.patch
and it can be found in the queue-3.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <[email protected]> know about it.
>From 62b62ad873f2accad9222a4d7ffbe1e93f6714c1 Mon Sep 17 00:00:00 2001
From: Boaz Harrosh <[email protected]>
Date: Fri, 8 Jun 2012 04:30:40 +0300
Subject: ore: Remove support of partial IO request (NFS crash)
From: Boaz Harrosh <[email protected]>
commit 62b62ad873f2accad9222a4d7ffbe1e93f6714c1 upstream.
Do to OOM situations the ore might fail to allocate all resources
needed for IO of the full request. If some progress was possible
it would proceed with a partial/short request, for the sake of
forward progress.
Since this crashes NFS-core and exofs is just fine without it just
remove this contraption, and fail.
TODO:
Support real forward progress with some reserved allocations
of resources, such as mem pools and/or bio_sets
[Bug since 3.2 Kernel]
CC: Benny Halevy <[email protected]>
Signed-off-by: Boaz Harrosh <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
fs/exofs/ore.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
--- a/fs/exofs/ore.c
+++ b/fs/exofs/ore.c
@@ -735,13 +735,7 @@ static int _prepare_for_striping(struct
out:
ios->numdevs = devs_in_group;
ios->pages_consumed = cur_pg;
- if (unlikely(ret)) {
- if (length == ios->length)
- return ret;
- else
- ios->length -= length;
- }
- return 0;
+ return ret;
}
int ore_create(struct ore_io_state *ios)
Patches currently in stable-queue which might be from [email protected] are
queue-3.4/ore-remove-support-of-partial-io-request-nfs-crash.patch
queue-3.4/ore-fix-nfs-crash-by-supporting-any-unaligned-raid-io.patch
queue-3.4/pnfs-obj-don-t-leak-objio_state-if-ore_write-read-fails.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html