commit: ce27e317ba22b359bde02216afab934dac3af095
From: Tejun Heo <[email protected]>
Date: Tue, 3 Jul 2012 10:38:06 -0700
Subject: cgroup: cgroup_rm_files() was calling simple_unlink() with the wrong 
inode

While refactoring cgroup file removal path, 05ef1d7c4a "cgroup:
introduce struct cfent" incorrectly changed the @dir argument of
simple_unlink() to the inode of the file being deleted instead of that
of the containing directory.

The effect of this bug is minor - ctime and mtime of the parent
weren't properly updated on file deletion.

Fix it by using @cgrp->dentry->d_inode instead.

Signed-off-by: Tejun Heo <[email protected]>
Reported-by: Al Viro <[email protected]>
Acked-by: Li Zefan <[email protected]>
Cc: [email protected]
---
 kernel/cgroup.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index dec62f5..a56805a 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -959,7 +959,7 @@ static int cgroup_rm_file(struct cgroup *cgrp, const struct 
cftype *cft)
 
                dget(d);
                d_delete(d);
-               simple_unlink(d->d_inode, d);
+               simple_unlink(cgrp->dentry->d_inode, d);
                list_del_init(&cfe->node);
                dput(d);
 
-- 
1.7.3.4
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to