On Wed, Aug 01, 2012 at 08:45:33AM -0700, Greg KH wrote:
> On Thu, Jul 26, 2012 at 03:55:41PM -0400, Gregs git-bot wrote:
> > commit: c5c4bdf02e518a281b229ae0891b346919e2d291
> > From: Sarah Sharp <[email protected]>
> > Date: Thu, 5 Jul 2012 09:41:22 -0700
> > Subject: USB: Remove unused LPM variable.
> > 
> > hub_initiated_lpm_disable_count is not used by any code, so remove it.
> > 
> > This commit should be backported to kernels as old as 3.5, that contain
> > the commit 8306095fd2c1100e8244c09bf560f97aca5a311d "USB: Disable USB
> > 3.0 LPM in critical sections."
> > 
> > Signed-off-by: Sarah Sharp <[email protected]>
> > Cc: [email protected]
> > ---
> >  include/linux/usb.h |    1 -
> >  1 files changed, 0 insertions(+), 1 deletions(-)
> > 
> > diff --git a/include/linux/usb.h b/include/linux/usb.h
> > index d4f9de1..dea2f0d 100644
> > --- a/include/linux/usb.h
> > +++ b/include/linux/usb.h
> > @@ -561,7 +561,6 @@ struct usb_device {
> >     struct usb3_lpm_parameters u1_params;
> >     struct usb3_lpm_parameters u2_params;
> >     unsigned lpm_disable_count;
> > -   unsigned hub_initiated_lpm_disable_count;
> >  };
> >  #define    to_usb_device(d) container_of(d, struct usb_device, dev)
> 
> I don't mind applying this patch, but why is it really needed for a
> stable kernel release?  It doesn't do anything, and I don't see any
> other patches depending on it.
> 
> Can the variable just safely live there in 3.5?

Eh, sure, if you feel it's not necessary, it's fine not to include it.

Sarah Sharp
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to