On Fri, Oct 19, 2012 at 01:45:27PM +0800, Tang Chen wrote: > cmci_rediscover() is only called by the CPU_POST_DEAD event handler, > which means the corresponding cpu has already dead. As a result, it > won't be accessed in the for_each_online_cpu loop. > So, we could change the if(cpu == dying) statement into a WARN_ON_ONCE(). > > Signed-off-by: Tang Chen <tangc...@cn.fujitsu.com> > --- > arch/x86/kernel/cpu/mcheck/mce_intel.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kernel/cpu/mcheck/mce_intel.c > b/arch/x86/kernel/cpu/mcheck/mce_intel.c > index 38e49bc..481d152 100644 > --- a/arch/x86/kernel/cpu/mcheck/mce_intel.c > +++ b/arch/x86/kernel/cpu/mcheck/mce_intel.c > @@ -180,8 +180,8 @@ void cmci_rediscover(int dying) > cpumask_copy(old, ¤t->cpus_allowed); > > for_each_online_cpu(cpu) { > - if (cpu == dying) > - continue; > + WARN_ON_ONCE(cpu == dying);
Ok, I don't understand that: we want to warn that the rediscovering is happening on a dying cpu?? And before that, we simply jumped over it and didn't do the rediscovering there? Why should we warn at all? Huh? -- Regards/Gruss, Boris. Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach GM: Alberto Bozzo Reg: Dornach, Landkreis Muenchen HRB Nr. 43632 WEEE Registernr: 129 19551 -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html