This is a note to let you know that I've just added the patch titled
target/iblock: Fix WCE=1 + DPOFUA=1 backend WRITE regression
to the 3.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
target-iblock-fix-wce-1-dpofua-1-backend-write-regression.patch
and it can be found in the queue-3.9 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <[email protected]> know about it.
>From d2bdbee0d91a5d3ba2e439ce889e20bfe6fd4f1b Mon Sep 17 00:00:00 2001
From: Nicholas Bellinger <[email protected]>
Date: Tue, 14 May 2013 23:41:04 -0700
Subject: target/iblock: Fix WCE=1 + DPOFUA=1 backend WRITE regression
From: Nicholas Bellinger <[email protected]>
commit d2bdbee0d91a5d3ba2e439ce889e20bfe6fd4f1b upstream.
This patch fixes a regression bug introduced in v3.9-rc1 where if the
underlying struct block_device for a IBLOCK backend is configured with
WCE=1 + DPOFUA=1 settings, the rw = WRITE assignment no longer occurs
in iblock_execute_rw(), and rw = 0 is passed to iblock_submit_bios()
in effect causing a READ bio operation to occur.
The offending commit is:
commit d0c8b259f8970d39354c1966853363345d401330
Author: Nicholas Bellinger <[email protected]>
Date: Tue Jan 29 22:10:06 2013 -0800
target/iblock: Use backend REQ_FLUSH hint for WriteCacheEnabled status
Note the WCE=1 + DPOFUA=0, WCE=0 + DPOFUA=1, and WCE=0 + DPOFUA=0 cases
are not affected by this regression bug.
Reported-by: Chris Boot <[email protected]>
Tested-by: Chris Boot <[email protected]>
Reported-by: Hannes Reinecke <[email protected]>
Signed-off-by: Nicholas Bellinger <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
drivers/target/target_core_iblock.c | 2 ++
1 file changed, 2 insertions(+)
--- a/drivers/target/target_core_iblock.c
+++ b/drivers/target/target_core_iblock.c
@@ -679,6 +679,8 @@ iblock_execute_rw(struct se_cmd *cmd)
rw = WRITE_FUA;
else if (!(q->flush_flags & REQ_FLUSH))
rw = WRITE_FUA;
+ else
+ rw = WRITE;
} else {
rw = WRITE;
}
Patches currently in stable-queue which might be from [email protected] are
queue-3.9/target-iblock-fix-wce-1-dpofua-1-backend-write-regression.patch
queue-3.9/iscsi-target-fix-processing-of-ooo-commands.patch
queue-3.9/target-close-target_put_sess_cmd-vs.-core_tmr_abort_task-race.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
