From: Tetsuo Handa <[email protected]> Subject: ocfs2: fix panic on kfree(xattr->name)
Commit 9548906b 'xattr: Constify ->name member of "struct xattr".' missed that ocfs2 is calling kfree(xattr->name). As a result, kernel panic occurs upon calling kfree(xattr->name) because xattr->name refers static constant names. This patch removes kfree(xattr->name) from ocfs2_mknod() and ocfs2_symlink(). Signed-off-by: Tetsuo Handa <[email protected]> Reported-by: Tariq Saeed <[email protected]> Tested-by: Tariq Saeed <[email protected]> Reviewed-by: Srinivas Eeda <[email protected]> Cc: Joel Becker <[email protected]> Cc: Mark Fasheh <[email protected]> Cc: <[email protected]> [3.12+] Signed-off-by: Andrew Morton <[email protected]> --- fs/ocfs2/namei.c | 2 -- 1 file changed, 2 deletions(-) diff -puN fs/ocfs2/namei.c~ocfs2-fix-panic-on-kfreexattr-name fs/ocfs2/namei.c --- a/fs/ocfs2/namei.c~ocfs2-fix-panic-on-kfreexattr-name +++ a/fs/ocfs2/namei.c @@ -450,7 +450,6 @@ leave: brelse(new_fe_bh); brelse(parent_fe_bh); - kfree(si.name); kfree(si.value); ocfs2_free_dir_lookup_result(&lookup); @@ -1856,7 +1855,6 @@ bail: brelse(new_fe_bh); brelse(parent_fe_bh); - kfree(si.name); kfree(si.value); ocfs2_free_dir_lookup_result(&lookup); if (inode_ac) _ -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
