This is a note to let you know that I've just added the patch titled

    irqchip: armada-370-xp: Fix releasing of MSIs

to the 3.14-stable tree which can be found at:
    
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     irqchip-armada-370-xp-fix-releasing-of-msis.patch
and it can be found in the queue-3.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <[email protected]> know about it.


>From ff3c664505bf8a8334bca5045e87b85cfe4d2277 Mon Sep 17 00:00:00 2001
From: Neil Greatorex <[email protected]>
Date: Fri, 18 Apr 2014 14:19:49 +0200
Subject: irqchip: armada-370-xp: Fix releasing of MSIs

From: Neil Greatorex <[email protected]>

commit ff3c664505bf8a8334bca5045e87b85cfe4d2277 upstream.

Store the value of d->hwirq in a local variable as the real value is wiped out
by calling irq_dispose_mapping. Without this patch, the armada_370_xp_free_msi
function would always free MSI#0, no matter what was passed to it.

Fixes: 31f614edb726fcc4d5aa0f2895fbdec9b04a3ca4 ('irqchip: armada-370-xp: 
implement MSI support')
Signed-off-by: Neil Greatorex <[email protected]>
Link: 
https://lkml.kernel.org/r/1397823593-1932-4-git-send-email-thomas.petazz...@free-electrons.com
Signed-off-by: Thomas Petazzoni <[email protected]>
Link: 
https://lkml.kernel.org/r/1397823593-1932-4-git-send-email-thomas.petazz...@free-electrons.com
Signed-off-by: Jason Cooper <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

---
 drivers/irqchip/irq-armada-370-xp.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

--- a/drivers/irqchip/irq-armada-370-xp.c
+++ b/drivers/irqchip/irq-armada-370-xp.c
@@ -156,8 +156,10 @@ static void armada_370_xp_teardown_msi_i
                                           unsigned int irq)
 {
        struct irq_data *d = irq_get_irq_data(irq);
+       unsigned long hwirq = d->hwirq;
+
        irq_dispose_mapping(irq);
-       armada_370_xp_free_msi(d->hwirq);
+       armada_370_xp_free_msi(hwirq);
 }
 
 static int armada_370_xp_check_msi_device(struct msi_chip *chip, struct 
pci_dev *dev,


Patches currently in stable-queue which might be from [email protected] are

queue-3.14/irqchip-armada-370-xp-fix-releasing-of-msis.patch
queue-3.14/irqchip-armada-370-xp-implement-the-check_device-msi_chip-operation.patch
queue-3.14/irqchip-armada-370-xp-fix-invalid-cast-of-signed-value-into-unsigned-variable.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to