On Wed, Jun 18, 2014 at 08:08:08PM -0700, [email protected] wrote:
>
> This is a note to let you know that I've just added the patch titled
>
> netlink: rate-limit leftover bytes warning and print process name
>
> to the 3.4-stable tree which can be found at:
>
> http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
>
> The filename of the patch is:
> netlink-rate-limit-leftover-bytes-warning-and-print-process-name.patch
> and it can be found in the queue-3.4 subdirectory.
>
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <[email protected]> know about it.
Oops, no, this breaks the build in a nasty error message:
CC lib/nlattr.o
In file included from include/linux/kernel.h:22:0,
from lib/nlattr.c:9:
lib/nlattr.c: In function ‘nla_parse’:
include/linux/printk.h:256:9: warning: type defaults to ‘int’ in declaration of
‘DEFINE_RATELIMIT_STATE’ [-Wimplicit-int]
static DEFINE_RATELIMIT_STATE(_rs, \
^
include/linux/printk.h:277:2: note: in expansion of macro ‘printk_ratelimited’
printk_ratelimited(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__)
^
lib/nlattr.c:200:3: note: in expansion of macro ‘pr_warn_ratelimited’
pr_warn_ratelimited("netlink: %d bytes leftover after parsing attributes in
process `%s'.\n",
^
lib/nlattr.c:200:3: warning: parameter names (without types) in function
declaration
In file included from include/linux/kernel.h:22:0,
from lib/nlattr.c:9:
include/linux/printk.h:256:9: error: invalid storage class for function
‘DEFINE_RATELIMIT_STATE’
static DEFINE_RATELIMIT_STATE(_rs, \
^
include/linux/printk.h:277:2: note: in expansion of macro ‘printk_ratelimited’
printk_ratelimited(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__)
^
lib/nlattr.c:200:3: note: in expansion of macro ‘pr_warn_ratelimited’
pr_warn_ratelimited("netlink: %d bytes leftover after parsing attributes in
process `%s'.\n",
^
lib/nlattr.c:200:3: error: implicit declaration of function ‘__ratelimit’
[-Werror=implicit-function-declaration]
In file included from include/linux/kernel.h:22:0,
from lib/nlattr.c:9:
include/linux/printk.h:260:19: error: ‘_rs’ undeclared (first use in this
function)
if (__ratelimit(&_rs)) \
^
include/linux/printk.h:277:2: note: in expansion of macro ‘printk_ratelimited’
printk_ratelimited(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__)
^
lib/nlattr.c:200:3: note: in expansion of macro ‘pr_warn_ratelimited’
pr_warn_ratelimited("netlink: %d bytes leftover after parsing attributes in
process `%s'.\n",
^
include/linux/printk.h:260:19: note: each undeclared identifier is reported
only once for each function it appears in
if (__ratelimit(&_rs)) \
^
include/linux/printk.h:277:2: note: in expansion of macro ‘printk_ratelimited’
printk_ratelimited(KERN_WARNING pr_fmt(fmt), ##__VA_ARGS__)
^
lib/nlattr.c:200:3: note: in expansion of macro ‘pr_warn_ratelimited’
pr_warn_ratelimited("netlink: %d bytes leftover after parsing attributes in
process `%s'.\n",
^
I can't see how this patch is causing a problem, anyone else?
thanks,
greg k-h
> lib/nlattr.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- a/lib/nlattr.c
> +++ b/lib/nlattr.c
> @@ -197,8 +197,8 @@ int nla_parse(struct nlattr **tb, int ma
> }
>
> if (unlikely(rem > 0))
> - printk(KERN_WARNING "netlink: %d bytes leftover after parsing "
> - "attributes.\n", rem);
> + pr_warn_ratelimited("netlink: %d bytes leftover after parsing
> attributes in process `%s'.\n",
> + rem, current->comm);
>
> err = 0;
> errout:
>
>
> Patches currently in stable-queue which might be from [email protected] are
>
> queue-3.4/netlink-rate-limit-leftover-bytes-warning-and-print-process-name.patch
> --
> To unsubscribe from this list: send the line "unsubscribe stable" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
