[
https://issues.apache.org/jira/browse/STANBOL-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172123#comment-13172123
]
Rupert Westenthaler commented on STANBOL-414:
---------------------------------------------
regarding Part-interface: You are right I was over engineering. for anonymous
content parts a URI defined (e.g. as a static member of this content type) is
good enough.
regarding Blob: We can also keep this methods - no problem - but if it is OK
for you I will change the implementation of the current available ContentItems
to internally use a Blob stored at index=0 of the ContentParts.
I have also changed the Constructor of your SinglePartContentItem to get the
Blob as second parameter to avoid calling the public "Blog getBlob()" method
within the constructor.
With your implementation there was a implicit requirement that getStream() and
getMimeType() is already functional while executing the super constructor of
the ContentItem. Parsing the Blob as parameter makes this more clear.
ContentItem implementations that do not want to load the blob at construction
(e.g. the WebContentItem) can use Blob implementation supporting lazy
initialization.
Reto if this is OK with you I will apply the patch after making the necessary
changes later today.
best
Rupert
> Refactor EnhancementEngine to support contents with multiple related parts
> --------------------------------------------------------------------------
>
> Key: STANBOL-414
> URL: https://issues.apache.org/jira/browse/STANBOL-414
> Project: Stanbol
> Issue Type: Improvement
> Reporter: Reto Bachmann-Gmür
> Attachments:
> 0001-CLEREZZA-414-changed-ContentItem-interface-and-utili.patch
>
>
> Some notes from a discussion with Rupert and Olivier
> ContentItem
> - getBlob() returns a blob of type multipart/mime iff the ContentItem was
> created from a multipart/mime content
> - ci.getBlob() eq ci.getPart(0, Blob.class)
> - ci.getUri()+"_main" eq ci.getPartUri(0)
> Rest
> /enhancer
> /enhancer/engine/<engineId>
> /enhancer/chains/<chaiId>
> - query params:
> Optional inputWithMetadata -> expects multipart/mime with 2 sections of which
> the first is rdf
> Optional outputWithContentParts[=<section-ordinal>] -> the result is
> multipart (instead of rdf) containing rdf as the first section and the parts
> in the second section, if there is more than one part this second section is
> itself multipart, this argument might be repated to have different sections
> Optional omitMetada -> no metadate in the result, makes only sense with
> outputContentParts argument, the result will correspond to the second section
> of the malipart returned without this argument
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
