Hi see my comments inline (Note that I removed points of the original mail with no comments)
Am 11.12.2010, 12:32 Uhr, schrieb Stefane Fermigier <[email protected]>: > Hi, > > during the trip back from Amsterdam I spent some time reviewing the > current Stanbol code base, and fixing some issues. > > Here are some remarks: > > 1. Stanbol doesn't build, it complains that > eu.iksproject:eu.iksproject.kres.shared.dependency.owlapi:jar:0.6-SNAPSHOT > is missing. > > This is a major issue since it prevents building the whole stack, and > putting it under continuous integration. > There is already an issue on that. see https://issues.apache.org/jira/browse/STANBOL-6 > 2. Lots of files (almost 600) have tabs instead of (or mixed with) > spaces. This is bad behavior, because, depending on how your editor is > set-up (tabs can be 2, 4 or 8 spaces long, depending on people choices), > some people will get ugly looking code. > > I have a massive patch that expands all the tabs to 8 spaces. Will apply > it soon, unless there is some protests. I usually use an intend of 2 spaces, so I would not be very happy with 8. > > - There are lots (~20) files that have been copied from geonames (I > believe). I'm not really happy about this, specially since > > a. It's not obvious which files have been modified and which ones have > been kept as-is. > > b. When file as been modified, it's not obvious where. I added the "Double getScore()" to the class "org.geonames.Toponym". This extension is needed by FISE to get score values for recommended locations. In addition I provided a pom that creates a bundle. More infors: - the discussion of the fise list: http://lists.iks-project.eu/pipermail/iks-fise/2010-July/000347.html - the issue with my changes on sourceforge.net http://sourceforge.net/tracker/index.php?func=detail&aid=3018007&group_id=175424&atid=873182 > > 8. Remember that interfaces are not the right place to define constants. > And it's usually better to use enums for integer constants (see Bloch's > Effective Java, 2nd ed., chapters 19 and 30). > Within RICK I used the Interfaces to define the string constants used as keys for the OSGI Configs. The intension of that was that implementations need not to invent there own keys to configure properties defined in the Interface. No problem to change that if that is against some kind of best practice. best Rupert Westenthaler |-- | Rupert Westenthaler [email protected] | Salzburg Research Forschungsgesellschaft http://www.salzburgresearch.at | Knowledge Based Information Systems +43 662 2288 413 | Jakob-Haringer Strasse 5/II Skype-Name: westei | A-5020 Salzburg
