Hi Jürgen, 2011/7/8 Jürgen Jakobitsch <[email protected]>: > hi all, > > before i'd commit to some stanbol core stuff, i'd like to offer > some serious refactoring of the existing code. > > 1. as mentioned during our hackathon : logging (there are huge amounts of > system.out || .err .print, printStackTraces and the like) > i'd try to find some consensus on log-levels (like for example here > http://thejoyofcode.com/Logging_Levels_and_how_to_use_them.aspx)
Yes, those sysout need to be eliminated. > 2. pom-refactoring : > 2.1 taking a look at some of the poms, i'd say this is a fine example of > "growing code" and copy and paste. > do for example an > - egrep -rl "junit" . --include=pom.xml > - egrep -rl "felix" . --include=pom.xml > in the root of the checkout. > junit for example is in the trunk-parent pom, so there's no need > anywhere else. chances are somebody will even use another version at > some point. Yes, our POMs are really grown by copy&paste in some areas. From time to time I already tried to improve the situation - so help is really appreciated. I don't know your experience with OSGI and Maven. The main problem is that with OSGI we have an additional layer that manages the dependencies at runtime. The Maven "runtime" dependencies don't help you anymore. That's why nearly everything is in scope "provided", Dependencies that are bundled (included) within an OSGI bundle are often in scope "compile" by then saying that everything that is in scope "compile" will be included when the bundle is packaged. Perhaps there are also better ways to deal with this. Best, - Fabian
