On Thu, Nov 3, 2011 at 10:00 AM, florent andré <[email protected]> wrote: > Refactoring the jobmanager for adding a chain capability involve to find a > name for the actual jobmanager impl (original class name is > inMemoryJobManager). >
The implementation in question * takes all active EnhancementEngines * orders them by weight (see ServiceProperties interface for details) * executes the Engines synchronously so > So for now we have : > - inmemoryjobmanager -1 because the fact that this is done in memory does not describe the implementation adequately > - simple +1 I still think this would be a good name, because this is basically a "simple" implementation and if someone comes up with a even more simple variant he can call it "simplest". > - default -1 Point taken ... we might change the default at some point > - static -1 because if an Engine becomes available and an oder is disabled or changes a property (e.g. the weight) this jobmanager adapts dynamically > - weighted +1 the fact that is orders the Engines based on weight is an important feature of this implementation best Rupert > > Any other ideas ? > Or consensus on the new baby name ? :) > > ++ > > On 11/02/2011 02:23 PM, Fabian Christ (Commented) (JIRA) wrote: >> >> [ >> https://issues.apache.org/jira/browse/STANBOL-370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142127#comment-13142127 >> ] >> >> Fabian Christ commented on STANBOL-370: >> --------------------------------------- >> >> +1 for not using camel case. >> >> About the naming we should think about what distinguishes the different >> job manager implementations. I'm -1 for "default" because the default might >> change in the future. "simple" is not good either because there may be a >> simpler one ;) What about "static" because it does not allow dynamic >> reordering? >> >> And perhaps the old eu.iksproject.fise packages could be renamed. >> >> >>> Change StanbolJobManager Structure >>> ---------------------------------- >>> >>> Key: STANBOL-370 >>> URL: https://issues.apache.org/jira/browse/STANBOL-370 >>> Project: Stanbol >>> Issue Type: Improvement >>> Reporter: Florent ANDRE >>> >>> The idea is to get a folder structure like Engines stuff for hold >>> Jobmanager implementations >>> This actually mean : >>> * move the Jobmanager folder from enhancer/generic/jobmanager to >>> enhancer/jobmanager >>> * create inside the jobmanager a pom and folders to hold differents >>> implementations. >>> * Create an inMemory folder for this implementation. >> >> -- >> This message is automatically generated by JIRA. >> If you think it was sent incorrectly, please contact your JIRA >> administrators: >> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa >> For more information on JIRA, see: http://www.atlassian.com/software/jira >> >> > -- | Rupert Westenthaler [email protected] | Bodenlehenstraße 11 ++43-699-11108907 | A-5500 Bischofshofen
