Hi Suat

Thanks for your work on FeaturedSearch. I think this the result will be
something that's easy to use and to integrate.

Just a few comments:

- I would keep the name ConstrainedDocumentSet rather than list as what it
represent is an intensionally defined set of documents, the fact that the
documents can be accessed as a list is secondary
- The search method with offset and limit are redudant with the subList
method of list, for pagination one can use the sublist method. I think this
is much clearer than having thd CDS representing only a single page in the
document list, I think the logical filtering by keywords and constraints
must happen before the presentational filtering by page.

Cheers,
Reto

Reply via email to