Thanks for the review! On 12/20/11 1:22 AM, Matthew Wild wrote: > On 16 December 2011 18:43, Peter Saint-Andre <stpe...@stpeter.im> wrote: >> The latest diff is here: >> >> http://xmpp.org/extensions/diff/api/xep/0045/diff/1.25rc8/vs/1.25rc9 >> >> The diff from 1.24 is here: >> >> http://xmpp.org/extensions/diff/api/xep/0045/diff/1.24/vs/1.25rc9 > > 7.2.10... "whether the definition" -> "where the definition"
Fixed. > 7.2.16... remove "(if any)" perhaps? (since the lack of subject is > covered by example 43). Agreed. > 7.2.17... "After the room has optionally sent the room subject" > perhaps contradicts the previous section? I gather it is more or less > required to send a subject in every case now? Yes. Fixed. > Everything else looks good. The diff reminded me of how ancient this > XEP is/was :) Indeed. I am hoping that after this version is completed, we can wait a year or so and advance it to Final. Peter -- Peter Saint-Andre https://stpeter.im/
