Hi, I always learned as coding style: Uint8 isIn; void putPixel(int x, int y, int col); etc.
I like it, because it's clear, and I see it more often then is_in and render_text. Regards, Gert-Jan > On Wed, Jan 12, 2005 at 02:17:50AM +0000, Pablo Nicolás Nuñez Pölcher > wrote: >> Hi, > > hi pablo, > >> I've finally finished writing the image class and the >> OpenGL support for 2D images. Should I upload it >> to the CVS or should it first be integrated into the >> project? > > first integrate it into the project. > > to all : please don't commit code to the cvs if it hasn't anything to do > with the project > >> TODO for me: Error checking when image files load. > > a few comments > > 1) > currently the method used to display the image is called > Image::GL_PutImage. we should rename it to something more like > image::display > > 2) > also, maybe we should start using a convention on how to name methods > and variables > > i try to use lower case only and "_" between words like > Uint8 is_in(Sint32 x, Sint32 y); > whereas you would write something like > Uint8 IsIn(Sint32 x, Sint32 y); > > we should choose something and keep it. > > i'll definitely write something about coding style > > 3) > alpha blending and transparency can be added later without too much > trouble I think but it'll be needed for integration > > 4) > i took a look at supertux's source code last night and there seems to be > endianness issues with opengl. maybe we should take care of that right > at the start ? > anyone has a macintosh here ? > > 5) > i'd like to avoid seeing opengl functions in the main code > > maybe but them in something like se::init_gl ? > > i'll also write an image engine class (like the sound engine: hash > tables to retrieve images) maybe we can put some methods in here too. > or maybe declare some static methods on the image class (methods used > for the whole class rather than a given instance) > > that's it > > thanks for this good work :) > > Fred > -- > Why fear computers ? They don't byte ! >
