An Event::handle for StartCheckPassword has been added to the common_check_user() function to enable the Authentication plugin.
To me the changes seem too complex. The original flow of the function was to: 1. check for empty password 2. get the user 3. test for valid user 3.1 test for valid password return USER | FALSE The changes in 0.9.x: 1. test StartCheckPassword 1.1 get the user 1.2 test for valid user 1.2.1 test password 1.3 fire off EndCheckPassword return USER | FALSE I think that the order could be more like the original 1. check for empty password (or eliminate this and delegate to the plugin) 2. get the user 3. fire off StartCheckPassword 4. test for valid user 4.1 test password (or eliminate this and delegate to the plugin) 5. fire off EndCheckPassword return USER | FALSE Executing "get the user" prior to the StartCheckPassword would allow plugins to act on any data in the user object. For example; specify a plugin to use for authentication, or; pass data to the plugin to update an LDAP record. thanks jim
_______________________________________________ StatusNet-dev mailing list [email protected] http://lists.status.net/mailman/listinfo/statusnet-dev
