On Wednesday 17 February 2010 22:46:32 Joachim Seibert wrote:
> Hi Evan,
> 
> > There's really little value in using relative URLs. If they're
> > incorporated into core, they will have to be carefully managed, since
> > links generated in this code go out in email, as part of Atom and RSS
> > feeds, and in OMB.
> 
> 
> yes, we discussed that already: Relative vs. absolute links. And yes:  
> we have different opinions to that.
> But in this case I can't find any reason, why an absolute link would  
> be important here.
> 
> The function, that has to produce relative urls to use status.net  
> under http and https is: lib/theme.php: "function theme_path".
> 
> You know the status.net code far better than me - I just made some  
> minor patches in my local copy - but I can't find any usage of the  
> theme_path function, where it's used to produce links for RSS or email.
> Usage like "lib/action.php: 'href="'.theme_path('css/ie.css', 'base')"  
> shouldn't effect any rss-code. So if theme_path will only be used to  
> reference CSS stylesheet files - as one would expect by it's name -  
> relative URLs should be ok.
> 

I've checked that the patch changes at lib/themes.php only change the URL path 
of CSS  (<link rel="stylesheet"...).

By other hand, using absolute URLs (without the patch) and using HTTPS, OMB 
subscription (from an user of my statusnet instance to an identi.ca user) 
doesn't work, I get "Not a valid profile URL (no YADIS document or invalid XRDS 
defined)".
The user profile "meta" link is linking to "<meta http-equiv="X-XRDS-Location" 
content="https://identi.ca/user/xrds"/>",  that url 
(https://identi.ca/user/xrds) exists and I think in the log the OAuth 
negotiaton is the same as with HTTP but with the HTTPS URL, but I've not 
investigated any more.

The OMB subscription log:

2010-02-17 13:53:20 LOG_DEBUG: [mistatus.com:23879.49a3c8d0 GET 
/index.php?action=finishremotesubscribe&omb_listener=http%3A%2F%2Fidenti.ca%2Fuser%2F119407&omb_listener_profile=http%3A%2F%2Fidenti.ca%2Fuser&omb_listener_homepage=http%3A%2F%2Frhizomatik.net&omb_listener_nickname=user&omb_listener_license=http%3A%2F%2Fcreativecommons.org%2Flicenses%2Fby%2F3.0%2F&omb_listener_fullname=user&omb_listener_location=ocean&omb_listener_avatar=http%3A%2F%2Favatar.identi.ca%2F119407-96-20100113052213.gif&oauth_token=9e6e6e609f3a2a9e4bc08759f3187898&omb_version=http%3A%2F%2Fopenmicroblogging.org%2Fprotocol%2F0.1&]
 
finishremotesubscribe.php - stored request: OMB_Service_Consumer Object
(
    [url:protected] => http://identi.ca/user
    [services:protected] => Array
        (
            [http://oauth.net/core/1.0/endpoint/request] => 
http://identi.ca/index.php?action=requesttoken
            [http://oauth.net/core/1.0/endpoint/authorize] => 
http://identi.ca/index.php?action=userauthorization
            [http://oauth.net/core/1.0/endpoint/access] => 
http://identi.ca/index.php?action=accesstoken
            [http://openmicroblogging.org/protocol/0.1/updateProfile] => 
http://identi.ca/index.php?action=updateprofile
            [http://openmicroblogging.org/protocol/0.1/postNotice] => 
http://identi.ca/index.php?action=postnotice
        )

    [token:protected] => OAuthToken Object
        (
            [key] => 9e6e6e609f3a2a9e4bc08759f3187898
            [secret] => 08eb8ecf731dfda017ed29445410f50f
        )

    [listener_uri:protected] => http://identi.ca/user/119407
    [listenee_uri:protected] => https://mistatus.com/index.php/user/1
    [performLegacyAuthRequest] => 1
    [fetcher:protected] => Auth_Yadis_ParanoidHTTPFetcher Object
        (
            [timeout] => 20
            [headers] => Array
                (
                )

            [data] => 
oauth_token=9e6e6e609f3a2a9e4bc08759f3187898&oauth_token_secret=08eb8ecf731dfda017ed29445410f50f
        )

    [oauth_consumer:protected] => OAuthConsumer Object
        (
            [key] => https://mistatus.com/
            [secret] =>
            [callback_url] =>
        )

    [datastore:protected] => StatusNetOAuthDataStore Object
        (
        )

)
_______________________________________________
StatusNet-dev mailing list
[email protected]
http://lists.status.net/mailman/listinfo/statusnet-dev

Reply via email to