Martin Sebor wrote: > >Travis Vitek wrote: >> >> The only thing I don't like about this patch is that it >> assumes no other platform will exhibit the same behavior >> that we are seeing on Linux/x86_64. I can't say with any >> confidence that things will actually work out that way. >> Personally I'd rather see the change compiled out by >> default on all platforms, and a macro to enable it if >> the user wants it. > >I'm not sure what you mean by "see the change compiled out on all >platforms." Are you saying you want the atomic ops disabled on >all platforms?
No, I'm definitely not saying disable atomic ops on all platforms. That would be silly. > The reason for this patch is because the atomic >ops hadn't been ported to x86_64 in time for 4.1.3 (bad mistake): > http://issues.apache.org/jira/browse/STDCXX-162 > Makes sense now. Sorry for the confusion. It has been a long day. >> >> Also, if you want to pick nits, the version check should probably use >> _RWSTD_VER_MAJOR. > >Yes, that would be better. I'll change it. > >Martin > >> >> Travis
