On Wed, Jun 1, 2011 at 12:03, Catalin Marinas <[email protected]> wrote: > I don't remember exactly. I probably just copied them from higher up > where the code was checking for __conflicting_push and setting > self.__patches again. I never got an in-depth understanding of the new > library code :) (and very little time to continue the conversion of > the left commands).
Aha, then I think I know: Before your change, the code used to do first the non-conflicting updates, then log, then the non-conflicting updates, then log again. Presumably, it needed to clean the transaction state in between. After your change, it was supposed to do all the changes in one go, then log, but you left in the state cleaning in the middle. Good to know there wasn't a good reason for it being there that'll bite us now that it's removed. > I merged your patches and pushed them to the stgit repo. Thanks again. Thanks. -- Karl Wiberg, [email protected] subrabbit.wordpress.com www.treskal.com/kalle _______________________________________________ stgit-users mailing list [email protected] https://mail.gna.org/listinfo/stgit-users
