[EMAIL PROTECTED] wrote on Wed, 14 Nov 2007 23:33 +0900:
> Moving connection allocation to transport would work better for iSER?
>
> This patch is against the lastest git tree
> (09532079071d65ec62dae982324ab07a895e16f1).
[..]
> -struct tcp_conn_info {
> +struct iscsi_tcp_connection {
> int fd;
> +
> + struct iscsi_connection iscsi_conn;
> };
Sure, good idea. It will create a bit of churn against the later
patches but easily fixed. Note that iser adds a task->trans_data
too; you could treat it similarly.
Also note the ep_conn_init() we need. It is called _after_ login
negotiation, not at allocation time, unlike your new conn_init().
May want to change the name so people aren't confused about this.
ep_task_init() is okay; it is called at task allocation time.
-- Pete
_______________________________________________
Stgt-devel mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/stgt-devel
