Is there a Jira ticket created?  Can someone create one?

-Ben Dewey

-----Original Message-----
From: Pablo Cibraro [mailto:pablo.cibr...@tellago.com] 
Sent: Monday, December 07, 2009 2:31 PM
To: stonehenge-dev@incubator.apache.org
Subject: RE: Hardcoded DAL Bug?

Hi Nick,

Yes, it's something I mentioned in the past. That's code is wrong and it needs 
to be fixed to support MySql as well.

Thanks
Pablo. 

-----Original Message-----
From: Nick Hauenstein [mailto:ni...@quicklearn.com] 
Sent: Monday, December 07, 2009 4:14 PM
To: stonehenge-dev@incubator.apache.org
Subject: Hardcoded DAL Bug?

Hello,

I was looking through the .NET implementation of the business service (in 
TradeService.cs), and found a few instances of code like the following:
dalCustomer = Trade.DALFactory.Customer.Create("Trade.DALSQLServer");

Instead of something like the following:
dalCustomer = 
Trade.DALFactory.Customer.Create(SQLHelper.GetAssemblyNameFromDBName(bsConfig.DBName));

It appears that we are hardcoding the usage of the SQL Server DAL in a few 
places within the service implementation. Is that a bug, or is there a purpose 
behind this?

- Nick

Reply via email to