If we return null instead of throwing an exception does that mean that PHP and the non-CBS implementation can call the BS the old way and still work as expected? If so, yes.
-Ben Dewey -----Original Message----- From: Pablo Cibraro [mailto:pablo.cibr...@tellago.com] Sent: Friday, December 11, 2009 2:31 PM To: stonehenge-dev@incubator.apache.org Subject: RE: (STONEHENGE-111) .NET Trader isn't using the userId claim returned from the ActiveSTS Oh, yes. You are right about that. Metro and .NET are both providing the user id claim in the saml token, as it should be a requirement for executing the business service. Shall we make that optional, and remove that line that throws the exception ? Thanks Pablo. -----Original Message----- From: Ben Dewey [mailto:ben.de...@26ny.com] Sent: Friday, December 11, 2009 4:22 PM To: stonehenge-dev@incubator.apache.org Subject: RE: (STONEHENGE-111) .NET Trader isn't using the userId claim returned from the ActiveSTS Pablo, My concern was that 'throw new Exception("The profile id claim was not provided by the Active STS");' (inside of GetUserIdClaim()) would get called if no claim exists and all the service implementation code would get faulted. -Ben Dewey -----Original Message----- From: Pablo Cibraro [mailto:pablo.cibr...@tellago.com] Sent: Friday, December 11, 2009 2:04 PM To: stonehenge-dev@incubator.apache.org Subject: RE: (STONEHENGE-111) .NET Trader isn't using the userId claim returned from the ActiveSTS No problem Ben. This is the code I am using, string userClaim = GetUserIdClaim(); if (userClaim != null) { userID = userClaim; } I am basically looking for the user id in the claims. If the claim is not found, the userID is not set, so the userID passed as argument in the operation is used. Otherwise, the user id in the claim is used. Does it make sense ? Thanks Pablo. -----Original Message----- From: Ben Dewey [mailto:ben.de...@26ny.com] Sent: Friday, December 11, 2009 3:55 PM To: stonehenge-dev@incubator.apache.org Subject: RE: (STONEHENGE-111) .NET Trader isn't using the userId claim returned from the ActiveSTS Pablo, > Could you apply it in the trunk when you have some time ?. I'll try to get around to it this weekend, but I'm going out-of-town, so if not I should be able to apply it on Monday night. Although, I just looked at the patch and have one question. It seems you are checking to see if GetUserIdClaim() == null, but the final line in that function throws an exception. Doesn't seem like that would work, am I reading that wrong? -Ben Dewey
