On Mon, 23 Feb 2009 10:07:13 -0500 Mike Frysinger <[email protected]> wrote:
> On Monday 23 February 2009 02:07:08 Hans-Christian Egtvedt wrote: > > Please see the linked patch[0] which adds AVR32 architecture > > support to strace. Implemented by Håvard Skinnemoen > > ([email protected]) and ported to latest CVS HEAD by me. > > > > The patch is based against current CVS HEAD. Tested on AP7000 with > > some random commands, and it seems to behave nice. I also tried > > going through the test/ directory, but they seem to be a bit > > outdated and a bit x86 specific AFAICT? > > > > If you have a preferred test suite, I can go through that as well. > > you forgot to add avr32/ioctlent.h to the Makefile.am for dist > Indeed, but it was not in use, dropped. > the 2nd hunk to defs.h is broken (look at the parenthesis) > Yes, Denys spotted that as well. > is there a reason for normalizing the ioctlent.h so it doesnt > resemble the output of ioctlsort anymore ? > File dropped. > do you really need your own ioctlent.sh ? cant we keep this merged > with the common linux one ? otherwise, you've forgotten to add this > to Makefile.am for dist too. > File dropped. > your syscallent.h seems to be lacking a lot of 5th arguments for > standard functions. i.e. sys_exit has SYS_exit, etc... > I've cleaned up the syscallent.h, added four missing system calls and gone over the number of arguments. Should be in shape now. Thanks for the review, I'll submit a revised patch shortly. -- Best regards, Hans-Christian Egtvedt ------------------------------------------------------------------------------ Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H _______________________________________________ Strace-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/strace-devel
