On Thu, Aug 05, 2010 at 02:40:45PM +0800, Wang Chao wrote: > * process.c (internal_wait): processes counted in tcp->nclone_threads > are tcp's threads, rather than tcp's children.
Looks OK to me, but see my comment below. > - got_kids = (tcp->nchildren > tcp->nclone_detached); > + got_kids = (tcp->nchildren > (tcp->nclone_detached + > tcp->nclone_threads)); There is a possibility to count a process with both CLONE_THREAD and CLONE_DETACHED flags set twice, but I'm doubt that such a combination of CLONE_ flags is real, since CLONE_DETACHED is officially no-op in kernel for a very long time. Maybe it would be even better to drop this nclone_detached completely from strace. -- ldv
pgpkVTHjBlte1.pgp
Description: PGP signature
------------------------------------------------------------------------------ This SF.net email is sponsored by Make an app they can't live without Enter the BlackBerry Developer Challenge http://p.sf.net/sfu/RIM-dev2dev
_______________________________________________ Strace-devel mailing list Strace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/strace-devel
