Re: [PATCH] unwind: disable stack trace with multiple personalities

[Dmitry V. Levin]

On Sun, Jun 08, 2014 at 09:29:23PM -0700, Luca Clementi wrote:
>  * unwind.c: disable stack tracing when tracing multiple
>    personalities
> ---
>  unwind.c |   30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
> 
> diff --git a/unwind.c b/unwind.c
> index ba7b579..99bfbe9 100644
> --- a/unwind.c
> +++ b/unwind.c
> @@ -104,6 +104,12 @@ unwind_init(void)
>  void
>  unwind_tcb_init(struct tcb *tcp)
>  {
> +#if UPPORTED_PERSONALITIES > 1
> +     if (tcp->currpers) {
> +             /* disable strack trace */
> +             return;
> +     }
> +#endif

Firstly, the check itself should be (tcp->currpers != DEFAULT_PERSONALITY).
Secondly, unwind_tcb_init and unwind_tcb_fin should not be changed because
process personality is not necessarily a constant.


-- 
ldv

pgpbA3cH9slyv.pgp
Description: PGP signature

------------------------------------------------------------------------------
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
Find What Matters Most in Your Big Data with HPCC Systems
Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
Leverages Graph Analysis for Fast Processing & Easy Data Exploration
http://www.hpccsystems.com
_______________________________________________
Strace-devel mailing list
Strace-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/strace-devel