On Sat, Mar 14, 2015 at 10:25:48PM +0530, Rohan Bavishi wrote: > Hi everyone, > > As I had mentioned in the thread before, I had planned to write some > small test-suite code in order to get familiar with the code base. I > have come up with some small preliminary test-benches covering > system-calls 'chdir' and 'fcntl'. I'm posting the Github link, so as > to not clutter this thread with long, boring code. > > Github: https://github.com/rbavishi/GSOC2015-strace > > Any critique/suggestion regarding coding style, errors, code quality > is much appreciated. > > Also, I did some crude hacks to include these tests in the Makefile > for testing, and both of them passed on my system.
There is no need to do crude hacks. I think it worth investing a few minutes in reading tests/Makefile.am to understand how to add new tests to the test suite. Also, please do not introduce yet another coding style. FYI, commit v4.10-18-g8f54664 simplified the shell part of test suite. -- ldv
pgpIcyVo7Fomg.pgp
Description: PGP signature
------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________ Strace-devel mailing list Strace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/strace-devel
