Hi, On Thu, Dec 10, 2015 at 10:54:55AM -0800, Elliott Hughes wrote: > other than one small patch to build (below and attached, since gmail > mangles these things), lgtm on Android. > > If we build strace against the untouched Linux kernel uapi headers (as used > by bionic), the key fields are called 'key', not '__key'. > > * ipc_msgctl.c, ipc_shmctl.c: Add #define workaround.
Both files already include "ipc_defs.h" which in turn defines __key to key in HAVE_LINUX_IPC_H case. Unless you define HAVE_LINUX_MSG_H and HAVE_LINUX_SHM_H without defining HAVE_LINUX_IPC_H (which is probably not the right thing to do), your patch will break build with linux uapi headers rather than fix it. -- ldv
pgpuzAMiLQoFX.pgp
Description: PGP signature
------------------------------------------------------------------------------
_______________________________________________ Strace-devel mailing list Strace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/strace-devel
