On Fri, May 13, 2016 at 11:32:55AM -0400, Jeff Mahoney wrote: > On 5/13/16 11:30 AM, Line Printer wrote: > > On Fri, May 13, 2016 at 6:01 PM, Jeff Mahoney <je...@suse.com> wrote: > >> On 5/13/16 10:57 AM, Line Printer wrote: > >>> On Thu, May 5, 2016 at 3:07 AM, <je...@suse.com> wrote: > >>>> From: Jeff Mahoney <je...@suse.com> > >>>> > >>>> btrfs.c | 1298 > >>>> ++++++++++++++++++++++++++++++++++++ > >>> > >>> Would you care to enrich your code with a number of tests? You seem to > >>> be most suitable for this task. > >> > >> I had started work on this, but the main issue is that you need an > >> actual file system to test and modify. It quickly turns into a btrfs > >> regression test suite instead of strace tests and introduces a > >> requirement on the btrfs userspace tools. > > > > Take a look at tests/ioctl_v4l2.c. By passing -1 as the first argument > > to ioctl(2) you should be able to test at least some requests. > > Testing EBADF seems like pretty pointless testing.
This way you can fully test all _IOW ioctls and partially test _IOWR ioctls, which is definitely better than nothing. -- ldv
pgp5lP1PwzlSi.pgp
Description: PGP signature
------------------------------------------------------------------------------ Mobile security can be enabling, not merely restricting. Employees who bring their own devices (BYOD) to work are irked by the imposition of MDM restrictions. Mobile Device Manager Plus allows you to control only the apps on BYO-devices by containerizing them, leaving personal data untouched! https://ad.doubleclick.net/ddm/clk/304595813;131938128;j
_______________________________________________ Strace-devel mailing list Strace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/strace-devel
