On Sun, May 15, 2016 at 10:24:22AM +0000, Fabien Siron wrote:
[...]
> > > + } req = {
> > > + .nlh = {
> > > + .nlmsg_len = sizeof(req),
> > > + .nlmsg_type = SOCK_DIAG_BY_FAMILY,
> > > + .nlmsg_flags = NLM_F_DUMP | NLM_F_REQUEST
> > > + },
> > > + .idr = {
> > > + .sdiag_family = AF_NETLINK,
> > > + .sdiag_protocol = NDIAG_PROTO_ALL,
> > > + .ndiag_ino = (unsigned) inode,
> >
> > Isn't implicit cast enough?
> >
> > BTW, inode lookup is not implemented anyway, so like in case of
> > unix_send_query, .ndiag_ino initialization has no practical purpose.
>
> Do you suggest to remove .ndiag_ino initialization?Yes, unless you want to leave it as a reminder of unimplemented kernel feature. -- ldv
pgpt5VP3Gl357.pgp
Description: PGP signature
------------------------------------------------------------------------------ Mobile security can be enabling, not merely restricting. Employees who bring their own devices (BYOD) to work are irked by the imposition of MDM restrictions. Mobile Device Manager Plus allows you to control only the apps on BYO-devices by containerizing them, leaving personal data untouched! https://ad.doubleclick.net/ddm/clk/304595813;131938128;j
_______________________________________________ Strace-devel mailing list Strace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/strace-devel
