On Tue, Jun 21, 2016 at 02:42:43PM +0000, Fabien Siron wrote: > This commit introduces a new type iov_decode which will be used instead > of the integer "decode" as a parameter.
The first line of commit message shouldn't end with dot.
No need to begin each commit message with "This commit introduces",
a simple "Introduce" is enough.
[...]
> + switch (c->decode_iov) {
> + case IOV_DECODE_STR:
> + {
> + if (len > c->data_size)
> + len = c->data_size;
> + c->data_size -= len;
> + printstr(tcp, iov[0], len);
> + break;
> + }
These braces are redundant.
--
ldv
pgp1B89Yje3Ug.pgp
Description: PGP signature
------------------------------------------------------------------------------ Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San Francisco, CA to explore cutting-edge tech and listen to tech luminaries present their vision of the future. This family event has something for everyone, including kids. Get more information and register today. http://sdm.link/attshape
_______________________________________________ Strace-devel mailing list Strace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/strace-devel
