On Wed, Jun 22, 2016 at 01:27:04PM +0000, Fabien Siron wrote:
> Introduce a general socket netlink parser which prints
> the header and a string for the remaining part of the buffer. It doesn't
> handle all the netlink flags and types because the parser needs more
> information. It will be done soon.

Please format this paragraph.

> * net.c (printsock): Return family.

Change return type to int.
Return socket family on success and -1 in case of an error.

> (do_msghdr): Call tprint_iov_upto() for netlink decoding.

(do_msghdr): Pass IOV_DECODE_NETLINK to tprint_iov_upto() for netlink
sockets.

> (send, sendto, recv, recvfrom): Call printsockbuf().

(printsockbuf): New function.
(SYS_FUNC(send), SYS_FUNC(sendto), SYS_FUNC(recv), SYS_FUNC(recvfrom)):
Use it instead of printstr.

> * netlink.c: New file.
> (decode_netlink): New function.

* netlink.c: New file.
* Makefile.am (strace_SOURCES): Add it.

> @@ -936,11 +960,13 @@ SYS_FUNC(recvfrom)
>               printfd(tcp, tcp->u_arg[0]);
>               tprints(", ");
>       } else {
> +
>               /* buf */

No need to add an empty line here.


-- 
ldv

Attachment: pgpyMBJmFf5tZ.pgp
Description: PGP signature

------------------------------------------------------------------------------
Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San
Francisco, CA to explore cutting-edge tech and listen to tech luminaries
present their vision of the future. This family event has something for
everyone, including kids. Get more information and register today.
http://sdm.link/attshape
_______________________________________________
Strace-devel mailing list
Strace-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/strace-devel

Reply via email to